Preserve object prototypes when cloning (v2) #7404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm not sure that we're going to have another release of 2.9. I'm not against merging this, but the safer route is probably to upgrade to Chart.js 3.0. We're getting close to doing another alpha or beta release that will have the fix |
Author
|
I'm working on upgrading to 3.0, I figured this could go in the next bugfix release on 2.9, but didn't realize such a release wasn't in the plans. |
kurkle
approved these changes
May 24, 2020
etimberg
approved these changes
May 31, 2020
GramParallelo
added a commit
to GramParallelo/Chart.js
that referenced
this pull request
Mar 23, 2022
This reverts commit 484f0d1.
GramParallelo
added a commit
to WalkerTracker/Chart.js
that referenced
this pull request
Mar 24, 2022
This reverts commit 484f0d1.
typpo
added a commit
to typpo/Chart.js
that referenced
this pull request
Jan 15, 2023
This reverts commit 484f0d1.
This was referenced Aug 16, 2024
This was referenced Sep 8, 2024
This was referenced Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #7381, fixing #7340 for v2. Test was modified to support ES5.