criu: Allow disabling freeze cgroups #2475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesus-ramos
approved these changes
Sep 12, 2024
Contributor
jesus-ramos
left a comment
jesus-ramos
left a comment
There was a problem hiding this comment.
LGTM from the CUDA side, thanks Andrei.
rst0git
reviewed
Sep 12, 2024
avagin
force-pushed
the
cude-vs-cgroup-freezer
branch
from
d77f04c to
f638b6c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+26
to
+32
| switch (fi_strategy) { | ||
| case FI_DISABLE_FREEZE_CGROUP: | ||
| dont_use_freeze_cgroup(); | ||
| break; | ||
| default: | ||
| break; | ||
| }; |
Check notice
Code scanning / CodeQL
No trivial switch statements
Snorch
reviewed
Sep 13, 2024
Some plugins (e.g., CUDA) may not function correctly when processes are frozen using cgroups. This change introduces a mechanism to disable the use of freeze cgroups during process seizing, even if explicitly requested via the --freeze-cgroup option. The CUDA plugin is updated to utilize this new mechanism to ensure compatibility. Signed-off-by: Andrei Vagin <[email protected]>
Adds a new "fault" to call dont_use_freeze_cgroup.
avagin
force-pushed
the
cude-vs-cgroup-freezer
branch
from
f638b6c to
895a7a7
Compare
This was referenced Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some plugins (e.g., CUDA) may not function correctly when processes are frozen using cgroups. This change introduces a mechanism to disable the use of freeze cgroups during process seizing, even if explicitly requested via the --freeze-cgroup option.
Fixes #2470