Skip to content

seize: fix pause devices for frozen containers #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avagin merged 1 commit into from
May 15, 2025
Merged

seize: fix pause devices for frozen containers #2665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions criu/seize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1060,22 +1060,32 @@ int collect_pstree(void)
*/
alarm(opts.timeout);

ret = run_plugins(PAUSE_DEVICES, pid);
if (ret < 0 && ret != -ENOTSUP) {
goto err;
}

if (opts.freeze_cgroup && cgroup_version())
goto err;

pr_debug("Detected cgroup V%d freezer\n", cgroup_v2 ? 2 : 1);

if (opts.freeze_cgroup && !compel_interrupt_only_mode) {
ret = run_plugins(PAUSE_DEVICES, pid);
if (ret < 0 && ret != -ENOTSUP) {
goto err;
}

if (freeze_processes())
goto err;
} else {
if (opts.freeze_cgroup && prepare_freezer_for_interrupt_only_mode())
goto err;

/*
* Call PAUSE_DEVICES after prepare_freezer_for_interrupt_only_mode()
* to be able to checkpoint containers in a frozen state.
*/
ret = run_plugins(PAUSE_DEVICES, pid);
if (ret < 0 && ret != -ENOTSUP) {
goto err;
}

if (compel_interrupt_task(pid)) {
set_cr_errno(ESRCH);
goto err;
Expand Down Expand Up @@ -1136,4 +1146,4 @@ int checkpoint_devices(void)
exit_code = 0;
err:
return exit_code;
}
}
Loading