Skip to content

make: don't install external dependencies #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avagin merged 3 commits into from
Oct 21, 2025
Merged

make: don't install external dependencies #2792

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fe3446
make: don't install external dependencies
rst0git Oct 21, 2025
0283ce9
ci: add wheel and setuptools in dnf packages
rst0git Oct 21, 2025
4c92830
ci: add which dependency in dnf packages
rst0git Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
make: don't install external dependencies 
Don't install external pip dependencies when running `make install`.
As we are not really into developing a Python project, we should
not install additional packages. CRIU does that nowhere else.

Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
  • Loading branch information
@rst0git
rst0git committed Oct 21, 2025
commit 4fe34461e648ee56e9589d1d4a88f73b0432c526
10 changes: 7 additions & 3 deletions Makefile.install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,13 @@ endif
endif

# Default flags for pip install:
# --upgrade: Upgrade crit/pycriu packages
# --ignore-installed: Ignore existing packages and reinstall them
PIPFLAGS ?= --upgrade --ignore-installed
# --ignore-installed: Overwrite already installed pycriu/crit packages
# --no-build-isolation: Use current Python environment to build pycriu/crit packages
# --no-deps: Don't install any dependencies
# --no-index: Don't use PyPI index to find packages
# --progress-bar: Cleaner output
# --upgrade: Treat the install as an upgrade when replacing the installed version
PIPFLAGS ?= --ignore-installed --no-build-isolation --no-deps --no-index --progress-bar off --upgrade

export SKIP_PIP_INSTALL PIPFLAGS

Expand Down
Loading