Skip to content

Conversation

@guptapratykshh
Copy link

Issue: #18024

Resolve Pitest Suppressions - common

This PR resolves issue #18024 by killing all 36 mutations from pitest-common-suppressions.xml and removing them from the suppression file.

Changes:

  • Added SimpleTokenTest with 15 tests covering SimpleToken mutations
  • Added JavadocCommentsLexerUtilTest with 12 tests covering JavadocCommentsLexerUtil mutations
  • Added JavadocCommentsParserUtilTest with 1 test covering JavadocCommentsParserUtil mutations
  • Enhanced LocalizedMessageTest with testArgsFieldIsSetToNullWhenArgsIsNull method
  • Enhanced SarifLoggerTest with testRenderSeverityLevelAllLevels method
  • Updated pom.xml to include new test classes in pitest-common profile targetTests
  • Removed all 36 mutations from pitest-common-suppressions.xml

All tests are passing (30 tests total, 0 failures).

@guptapratykshh guptapratykshh force-pushed the issue-18024-resolve-pitest-suppressions-common branch from e85ee30 to e4da7ba Compare November 30, 2025 14:30
@guptapratykshh guptapratykshh force-pushed the issue-18024-resolve-pitest-suppressions-common branch from e4da7ba to 9c9e31f Compare November 30, 2025 14:35
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

<?xml version="1.0" encoding="UTF-8"?>
<suppressedMutations>
<mutation unstable="false">
<sourceFile>JavadocCommentsLexerUtil.java</sourceFile>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this class is excluded from jacoco

<exclude>com.puppycrawl.tools.checkstyle.grammar.JavadocCommentsLexerUtil</exclude>

so it should be excluded from pitest also.

I think we need something like

<avoidCallsTo>com.puppycrawl.tools.checkstyle.utils.UnmodifiableCollectionUtil</avoidCallsTo>

for "common" profile

<id>pitest-common</id>

@mahfouz72 , do you agree ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants