cleaned Select from hardcoded Strings #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should change the name of method getWhereCond to getWhereClause, since is a getter for the variable whereClause |
There was a problem hiding this comment.
could you add more meaningful names instead of "test"?
RoyMontoya
force-pushed
the
select-cleanup
branch
from
55f94b8 to
547c816
Compare
|
@satyan @sibeliusseraphini is there any chance that someone could check this and other pullrequest pending? |
|
@RoyMontoya I will try to take a look this week |
|
@sibeliusseraphini ok! thanks! |
sibelius
added a commit
that referenced
this pull request
Dec 2, 2015
cleaned Select from hardcoded Strings
|
@RoyMontoya merged thanks, sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using hard-coded Strings is not recommended, constant Strings are easier to understand and the code looks cleaner.
Also changed some of the if conditionals to a cleaner look.