Make SugarRecord API more versatile #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this should not change the API, but makes it easier to use.
Especially for cases like wanting to count for one specific value,
resulting in a where with only one or a few args.
Currently we need to create a String array for that, resulting in a
ugly new String[]{"bla"} block.
Now it is possible to directly pass "bla"
count was the motivation for this change, but I changed other signatures
where this was possible as well.
|
By analyzing the blame information on this pull request, we identified @dominicwong617, @JonatanSalas and @whoshuu to be potential reviewers |
Contributor
|
can u create a method overload so we can keep both versions (the old and the new one) ? |
Contributor
Author
|
@sibelius We do. This does not break backwards compatibility. |
Contributor
|
Great to know I will test ur branch and I will merge it |
Contributor
|
sorry for the long time to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should not change the API, but makes it easier to use.
Especially for cases like wanting to count for one specific value,
resulting in a where with only one or a few args.
Currently we need to create a String array for that, resulting in a
ugly new String[]{"bla"} block.
Now it is possible to directly pass "bla"
count was the motivation for this change, but I changed other signatures
where this was possible as well.