Skip to content

Set STORYBOOK_INVOKED_BY env var for SB telemetry #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codykaup merged 3 commits into from
Jun 9, 2025
Merged

Set STORYBOOK_INVOKED_BY env var for SB telemetry #1180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1de7f63
Change env var to `STORYBOOK_INVOKED_BY`
tmeasday May 19, 2025
05b38f5
Set `STORYBOOK_NODE_ENV` on build command
tmeasday May 19, 2025
ddc9b95
Fix test
tmeasday May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions node-src/tasks/build.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,9 @@ describe('buildStorybook', () => {
await buildStorybook(ctx);
expect(command).toHaveBeenCalledWith(
ctx.buildCommand,
expect.objectContaining({ env: { CI: '1', NODE_ENV: 'production' } })
expect.objectContaining({
env: { CI: '1', NODE_ENV: 'production', STORYBOOK_INVOKED_BY: 'chromatic' },
})
);
});

Expand All @@ -204,7 +206,9 @@ describe('buildStorybook', () => {
await buildStorybook(ctx);
expect(command).toHaveBeenCalledWith(
ctx.buildCommand,
expect.objectContaining({ env: { CI: '1', NODE_ENV: 'test' } })
expect.objectContaining({
env: { CI: '1', NODE_ENV: 'test', STORYBOOK_INVOKED_BY: 'chromatic' },
})
);
});
});
Expand Down
6 changes: 5 additions & 1 deletion node-src/tasks/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,11 @@ export const buildStorybook = async (ctx: Context) => {
// action (node20), not the version set in the workflow
preferLocal: false,
signal,
env: { CI: '1', NODE_ENV: ctx.env.STORYBOOK_NODE_ENV || 'production' },
env: {
CI: '1',
NODE_ENV: ctx.env.STORYBOOK_NODE_ENV || 'production',
STORYBOOK_INVOKED_BY: 'chromatic',
},
});
await Promise.race([subprocess, timeoutAfter(ctx.env.STORYBOOK_BUILD_TIMEOUT)]);
} catch (err) {
Expand Down
Loading