Skip to content

Conversation

@AnnaCouthuresIdrizi
Copy link
Contributor

No description provided.

@github-actions
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

sciences-po-ecole-doctorale-author-date.csl (modified style)
(Hancké et al. (eds.), 2007; 2012)
(Mares, 2001; Fenner et al., 2019)

CSL search by example. 2012. URL : http://editor.citationstyles.org/searchByExample/ [accessed December 15, 2012].
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, et al. “A data citation roadmap for scholarly data repositories,” Scientific Data. 10 April 2019, vol.6 no. 1. p.28. URL : http://www.nature.com/articles/s41597-019-0031-8 [accessed April 27, 2019].
Hancké, Bob, Martin Rhodes, and Mark Thatcher (eds.). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York : Oxford University Press. 2007.
Mares, Isabela. “Firms and the welfare state: When, why, and how does social policy matter to employers?” in Peter A. Hall and David Soskice (eds.). Varieties of capitalism. The institutional foundations of comparative advantage. New York : Oxford University Press. 2001, p.184–213.
 (Hancké et al. (eds.), 2007; 2012)<br/>
 (Mares, 2001; Fenner et al., 2019)<br/>
 <hr/>
-<i>CSL search by example</i>. 2012. En ligne : http://editor.citationstyles.org/searchByExample/ [consulté le 15 décembre 2012].<br/>
-<span style="font-variant: small-caps">Fenner</span>, Martin, Mercè <span style="font-variant: small-caps">Crosas</span>, Jeffrey S. <span style="font-variant: small-caps">Grethe</span>, et al. « A data citation roadmap for scholarly data repositories », <i>Scientific Data</i>. 10 avril 2019, vol.6 nᵒ 1. p.28. En ligne : http://www.nature.com/articles/s41597-019-0031-8 [consulté le 27 avril 2019].<br/>
-<span style="font-variant: small-caps">Hancké</span>, Bob, Martin <span style="font-variant: small-caps">Rhodes</span>, et Mark <span style="font-variant: small-caps">Thatcher</span> (eds.). <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York : Oxford University Press. 2007.<br/>
-<span style="font-variant: small-caps">Mares</span>, Isabela. « Firms and the welfare state: When, why, and how does social policy matter to employers? » in <span style="font-style: normal"><span style="font-style: normal">Peter A. <span style="font-variant: small-caps">Hall</span></span> et <span style="font-style: normal">David <span style="font-variant: small-caps">Soskice</span></span></span> (eds.). <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>. New York : Oxford University Press. 2001, p.184‑213.<br/>
+<i>CSL search by example</i>. 2012. URL : http://editor.citationstyles.org/searchByExample/ [accessed December 15, 2012].<br/>
+<span style="font-variant: small-caps">Fenner</span>, Martin, Mercè <span style="font-variant: small-caps">Crosas</span>, Jeffrey S. <span style="font-variant: small-caps">Grethe</span>, et al. “A data citation roadmap for scholarly data repositories,” <i>Scientific Data</i>. 10 April 2019, vol.6 no. 1. p.28. URL : http://www.nature.com/articles/s41597-019-0031-8 [accessed April 27, 2019].<br/>
+<span style="font-variant: small-caps">Hancké</span>, Bob, Martin <span style="font-variant: small-caps">Rhodes</span>, and Mark <span style="font-variant: small-caps">Thatcher</span> (eds.). <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York : Oxford University Press. 2007.<br/>
+<span style="font-variant: small-caps">Mares</span>, Isabela. “Firms and the welfare state: When, why, and how does social policy matter to employers?” in <span style="font-style: normal"><span style="font-style: normal">Peter A. <span style="font-variant: small-caps">Hall</span></span> and <span style="font-style: normal">David <span style="font-variant: small-caps">Soskice</span></span></span> (eds.). <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>. New York : Oxford University Press. 2001, p.184–213.<br/>

@AnnaCouthuresIdrizi
Copy link
Contributor Author

Hello,
Could you please validate this pull request before the end of July ?
Best regards,
Anna

@AnnaCouthuresIdrizi
Copy link
Contributor Author

Hello,
Please merge this request before students are coming back, please please please !
Best regards,
Anna

@AnnaCouthuresIdrizi
Copy link
Contributor Author

@adam3smith Dear Sebastian, I have tree merge request pending for months. What is happening with the Zotero team ?
best regards,,
Anna

@POBrien333
Copy link
Contributor

@AnnaCouthuresIdrizi
You'll see I've made a comment and fixed some issues. If you can, please adapt the author-date style to match the note style.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Jul 25, 2025
@bwiernik
Copy link
Member

@AnnaCouthuresIdrizi bumping the question from @POBrien333 above

@AnnaCouthuresIdrizi
Copy link
Contributor Author

yes, thank you for the reminder, this is already on my to do list for this week :)
Best regards,
Anna

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 25, 2025
@github-actions
Copy link

😟 There are some issues with your submission.

10 tests failed

chicago-annotated-bibliography: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

chicago-author-date-16th-edition: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

chicago-author-date-no-em-dash: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

chicago-author-date: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

chicago-library-list: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

chicago-note-bibliography-16th-edition: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

chicago-note-bibliography-with-ibid: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

chicago-note-bibliography: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

taylor-and-francis-chicago-author-date: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

turabian-author-date: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

Please check the test report for details.

@AnnaCouthuresIdrizi
Copy link
Contributor Author

@POBrien333 is everything in order, now ? best, anna

@POBrien333
Copy link
Contributor

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 29, 2025
@github-actions
Copy link

😟 There are some issues with your submission.

10 tests failed

chicago-annotated-bibliography: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

chicago-author-date-16th-edition: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

chicago-author-date-no-em-dash: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

chicago-author-date: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

chicago-library-list: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

chicago-note-bibliography-16th-edition: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

chicago-note-bibliography-with-ibid: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

chicago-note-bibliography: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

taylor-and-francis-chicago-author-date: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

turabian-author-date: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

Please check the test report for details.

@POBrien333
Copy link
Contributor

@AnnaCouthuresIdrizi
I've made some changes, but there is still a bunch of hardcoded french words in the style that would need to be removed/replaced.

@github-actions
Copy link

😟 There are some issues with your submission.

10 tests failed

chicago-annotated-bibliography: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

chicago-author-date-16th-edition: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

chicago-author-date-no-em-dash: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

chicago-author-date: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

chicago-library-list: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

chicago-note-bibliography-16th-edition: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

chicago-note-bibliography-with-ibid: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

chicago-note-bibliography: may not have any unused macros

expected: []
     got: ["access-note", "container-contributors-note", "container-title-note", "contributors-note", "descript...ors-join-with-colon", "point-locators-join-with-comma", "secondary-contributors-note", "title-note"]

(compared using ==)

taylor-and-francis-chicago-author-date: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

turabian-author-date: may not have any unused macros

expected: []
     got: ["editor", "translator"]

(compared using ==)

Please check the test report for details.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

sciences-po-ecole-doctorale-author-date.csl (modified style)
(Hancké et al. (eds.), 2007; 2012)
(Mares, 2001; Fenner et al., 2019)

CSL search by example. 2012. URL : http://editor.citationstyles.org/searchByExample/ [accessed December 15, 2012].
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, et al. “A data citation roadmap for scholarly data repositories,” Scientific Data. 10 April 2019, vol.6 no. 1. p. 28. URL : https://www.nature.com/articles/s41597-019-0031-8 [accessed March 31, 2025].
Hancké, Bob, Martin Rhodes, and Mark Thatcher (eds.). Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy. Oxford : Oxford University Press. 2007. 438 p. URL : https://academic.oup.com/book/5397 [accessed ].
Mares, Isabela. “Firms and the welfare state: When, why, and how does social policy matter to employers?” in Peter A. Hall and David Soskice (eds.). Varieties of capitalism: The institutional foundations of comparative advantage. Oxford : Oxford University Press. 2001, p. 184–212. URL : https://academic.oup.com/book/301/chapter/134896619 [accessed ].
 (Hancké et al. (eds.), 2007; 2012)<br/>
 (Mares, 2001; Fenner et al., 2019)<br/>
 <hr/>
-<i>CSL search by example</i>. 2012. En ligne : http://editor.citationstyles.org/searchByExample/ [consulté le 15 décembre 2012].<br/>
-<span style="font-variant: small-caps">Fenner</span>, Martin, Mercè <span style="font-variant: small-caps">Crosas</span>, Jeffrey S. <span style="font-variant: small-caps">Grethe</span>, et al. « A data citation roadmap for scholarly data repositories », <i>Scientific Data</i>. 10 avril 2019, vol.6 nᵒ 1. p. 28. En ligne : https://www.nature.com/articles/s41597-019-0031-8 [consulté le 31 mars 2025].<br/>
-<span style="font-variant: small-caps">Hancké</span>, Bob, Martin <span style="font-variant: small-caps">Rhodes</span>, et Mark <span style="font-variant: small-caps">Thatcher</span> (eds.). <i>Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy</i>. Oxford : Oxford University Press. 2007. 438 p. En ligne : https://academic.oup.com/book/5397 [consulté le ].<br/>
-<span style="font-variant: small-caps">Mares</span>, Isabela. « Firms and the welfare state: When, why, and how does social policy matter to employers? » in <span style="font-style: normal"><span style="font-style: normal">Peter A. <span style="font-variant: small-caps">Hall</span></span> et <span style="font-style: normal">David <span style="font-variant: small-caps">Soskice</span></span></span> (eds.). <i>Varieties of capitalism: The institutional foundations of comparative advantage</i>. Oxford : Oxford University Press. 2001, p. 184‑212. En ligne : https://academic.oup.com/book/301/chapter/134896619 [consulté le ].<br/>
+<i>CSL search by example</i>. 2012. URL : http://editor.citationstyles.org/searchByExample/ [accessed December 15, 2012].<br/>
+<span style="font-variant: small-caps">Fenner</span>, Martin, Mercè <span style="font-variant: small-caps">Crosas</span>, Jeffrey S. <span style="font-variant: small-caps">Grethe</span>, et al. “A data citation roadmap for scholarly data repositories,” <i>Scientific Data</i>. 10 April 2019, vol.6 no. 1. p. 28. URL : https://www.nature.com/articles/s41597-019-0031-8 [accessed March 31, 2025].<br/>
+<span style="font-variant: small-caps">Hancké</span>, Bob, Martin <span style="font-variant: small-caps">Rhodes</span>, and Mark <span style="font-variant: small-caps">Thatcher</span> (eds.). <i>Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy</i>. Oxford : Oxford University Press. 2007. 438 p. URL : https://academic.oup.com/book/5397 [accessed ].<br/>
+<span style="font-variant: small-caps">Mares</span>, Isabela. “Firms and the welfare state: When, why, and how does social policy matter to employers?” in <span style="font-style: normal"><span style="font-style: normal">Peter A. <span style="font-variant: small-caps">Hall</span></span> and <span style="font-style: normal">David <span style="font-variant: small-caps">Soskice</span></span></span> (eds.). <i>Varieties of capitalism: The institutional foundations of comparative advantage</i>. Oxford : Oxford University Press. 2001, p. 184–212. URL : https://academic.oup.com/book/301/chapter/134896619 [accessed ].<br/>

@POBrien333
Copy link
Contributor

@AnnaCouthuresIdrizi
You reverted changes I had made to the style. Please undo those.
Note also that my comment about hardcoded terms in your code still stand and will need to be fixed before we can accept this style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants