-
Notifications
You must be signed in to change notification settings - Fork 9
Exponential search / Reasoning horizon #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielkocher
wants to merge
21
commits into
main
Choose a base branch
from
feat/exp-search
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
8a93aae
add: File horizon that implements the horizon extraction when the str…
danielkocher c3cd965
add: Stride option
danielkocher f70de50
feat: Exponential search when the stride option is enabled (up to a m…
danielkocher 1cf0b8c
fix: Remove Clone from Node type
danielkocher 29efb58
fix: Use absolute depth during unrolling and simplify print_reasoning…
danielkocher 127d2a9
feat: adds --one-query flag
a20b44a
feat: --one-query flag implemented for sat solvers
cdc6d11
fix: tiny fix sat_solvers
66fd804
feat: --one-query implemented for smt solvers
9ebe416
fix: add Node::or handle for smt solvers
5f7d495
fix: Node::Bad is now reachable in solvers
53e5203
fix: --one-query does not checks on bad states sequential
smml1996 c0757df
refactor: cargo fmt
smml1996 920c499
chore: add assertion for minimize when --one-query flag is used
smml1996 f892b6e
chore: Merge feat-one-query into feat/exp-search WIP
danielkocher 3088960
chore: Resolve merge conflict
danielkocher 9d798de
chore: Resolve merge conflict
danielkocher 8c23cf0
chore: Resolve merge conflict
danielkocher fa39d57
feat: Draft of reasoning horizon for a give time budget in ms (exp. s…
danielkocher 992b02b
fix: Quick fix that respect the stride option when the SMT solver is …
danielkocher ab2ef8f
iter: Fix reasoning horizon functionality (deal with updated order of…
danielkocher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Use absolute depth during unrolling and simplify print_reasoning…
…_horizon
- Loading branch information
commit 29efb58c0992f6ddc47da77956c3db21ce1c65f8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second parameter to
unroll_model(i.e. them) is only used to construct the names of bad-state nodes and input nodes in the current unrolling step. Would it make the algorithm simpler if we were to pass the correct absolute depth at this point already? I think this could makeprint_reasoning_horizonsimpler.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good pointer, thanks.
I adapted the implementation accordingly and
print_reasoning_horizondid simplify significantly (as expected).