Skip to content

Fix ghost element hiding #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2017
Merged

Fix ghost element hiding #172

merged 1 commit into from
Apr 5, 2017

Conversation

amje
Copy link
Contributor

@amje amje commented Mar 28, 2017

Hi,

Currently, setting visibility: hidden on ghost element not guarantees its hiding. According to spec, descendants will be visible if they have visibility: visible. So additional opacity: 0 should fix this.

clauderic
clauderic requested changes Apr 5, 2017
View reviewed changes
Copy link
Owner

@clauderic clauderic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @amje, thanks for submitting this!

Just one thing, you're currently overwriting the node.style property, you'll have to assign to the node.style.visibility and node.style.opacity properties directly instead.

@amje
Copy link
Contributor Author

amje commented Apr 5, 2017

@clauderic done

@clauderic clauderic merged commit ae0dd23 into clauderic:master Apr 5, 2017
@amje amje deleted the ghost-visibility branch April 5, 2017 13:08
DimitarNestorov pushed a commit to codemotionapps/react-sortable-hoc that referenced this pull request Feb 4, 2019
Merge pull request clauderic#172 from amje/ghost-visibility
f43f528 
Fix ghost element hiding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clauderic clauderic clauderic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amje @clauderic