Skip to content

Fix buggy special-display-buffer-names check. #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2024
Merged

Fix buggy special-display-buffer-names check. #3673

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2d22c4
Fix buggy special-display-buffer-names check.
PhilHudson May 21, 2024
1ff9662
Doco for PR #3673.
PhilHudson May 21, 2024
5551569
Merge branch 'master' into master
bbatsov May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Doco for PR #3673.
  • Loading branch information
@PhilHudson
PhilHudson committed May 21, 2024
commit 1ff966208b9535e38ca3149eeddd97d71ef942dc
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@

### Bugs fixed

- [#3673](https://github.com/clojure-emacs/cider/pull/3673): Fix buggy `special-display-buffer-names` check.
- [#3600](https://github.com/clojure-emacs/cider/pull/3600): Fix scittle jack-in when using `cider-jack-in-clj`.
- [#3663](https://github.com/clojure-emacs/cider/issues/3663): Fix `cider-interactive-eval-override` invocation.

Expand Down
3 changes: 3 additions & 0 deletions cider-popup.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ by adding BUFFER-NAME to the `special-display-buffer-names' list."
;; another time through `cider-popup-buffer-display'):
(if (and (boundp 'special-display-buffer-names)
(seq-find (lambda (entry)
;; Fix issue #3672 Phil Hudson 2024-05-21
;; entry can be either a list or a string
;; Previous code falsely assumed entry is always a list
(equal (if (listp entry) (car entry) entry) buffer-name))
Copy link
Member

@bbatsov bbatsov May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because code in function cider-popup-display-buffer falsely assumes that each element of special-display-buffer-names is a list. In fact and as documented, each element can be either a string or a list (the car of which is a string).

Can you add some variant of this as a comment here for clarity's sake?

special-display-buffer-names))
(progn
Expand Down