Skip to content

Consider all clojure sexps as defuns #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Consider all clojure sexps as defuns #32

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c1895f
Accept all sexp-nodes as defuns
kommen Feb 8, 2024
c437b6c
Add changelog entry and a note for reasoning about `treesit-defun-typ…
kommen Feb 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clojure-ts-mode.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,7 +917,7 @@ See `clojure-ts--font-lock-settings' for usage of MARKDOWN-AVAILABLE."
(setq-local treesit-defun-prefer-top-level t)
(setq-local treesit-defun-tactic 'top-level)
(setq-local treesit-defun-type-regexp
(cons (rx (or "list_lit" "vec_lit" "map_lit"))
(cons (regexp-opt clojure-ts--sexp-nodes)
Copy link
Member

@bbatsov bbatsov Feb 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add some note explaining this, so someone wouldn't fix down the road. :-)

(lambda (node)
(or (not clojure-ts-toplevel-inside-comment-form)
(not (clojure-ts--definition-node-p "comment" node))))))
Expand Down