Use miniflare.dispatchFetch in place of worker.fetch
#11137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9077c9e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
jamesopstad
force-pushed
the
james/use-dispatch-fetch
branch
from
0b59ade to
be441f1
Compare
jamesopstad
commented
Oct 30, 2025
Comment on lines
-56
to
-66
| override async unstable_canFetch(request: Request) { | ||
| // the 'sec-fetch-mode: navigate' header is stripped by something on its way into this worker | ||
| // so we restore it from 'x-mf-sec-fetch-mode' | ||
| const secFetchMode = request.headers.get("X-Mf-Sec-Fetch-Mode"); | ||
|
|
||
| if (secFetchMode) { | ||
| request.headers.set("Sec-Fetch-Mode", secFetchMode); | ||
| } | ||
|
|
||
| return await super.unstable_canFetch(request); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is no longer needed because it's handled in Miniflare.
Contributor
|
Can we also remove the custom cdn-cgi triggers handling? |
Contributor
Author
We can remove the extra plugin and put the trigger handling in the |
petebacondarwin
approved these changes
Oct 31, 2025
jamesopstad
force-pushed
the
james/use-dispatch-fetch
branch
from
be441f1 to
06640fa
Compare
jamesopstad
force-pushed
the
james/use-dispatch-fetch
branch
from
06640fa to
9077c9e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #000.
Switch all instances of
miniflare.getWorker()followed byworker.fetch()to useminiflare.dispatchFetch(). This means that the Vite plugin now emulates Cloudflare's response encoding in the same way as Wrangler.