enable environment targeting in config patching with wrangler deploy --x-remote-diff-check

[dario-piotrowicz]

Fixes #10894

Followup for #11033

This PR enables wrangler deploy --x-remote-diff-check to also update the local config file when an environment is targeted

---

• Tests
  • Tests included
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: UX improvement not requiring documentation
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: this feature is not included in v3

[changeset-bot]

🦋 Changeset detected

Latest commit: 8ecc46f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11160

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11160

miniflare

npm i https://pkg.pr.new/miniflare@11160

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11160

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11160

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11160

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11160

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11160

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11160

wrangler

npm i https://pkg.pr.new/wrangler@11160

commit: 8ecc46f

[penalosa]

Do we actually need this logic? The top level keys seem to be:

"legacy_env" | "send_metrics" | "dev" | "site" | "wasm_modules" | "text_blobs" | "data_blobs" | "alias" | "keep_vars"

and the constructed remote config (from convertWorkerToWranglerConfig()) doesn't insert any of those, I don't think.

[dario-piotrowicz]

yes, this is more of a future proofing mechanism to ensure that we don't end up doing that if later down the line there are such keys, if you believe this not to be necessary I'm happy to remove this logic 👍