Skip to content

Support pickling of functions with positional-only arguments #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogrisel merged 23 commits into from
May 14, 2019
Merged

Support pickling of functions with positional-only arguments #269

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
35446dc
adapt to Python3.8 with PEP570
stonebig May 11, 2019
273e723
update cloudpickle
stonebig May 11, 2019
04e2909
implement same test as for ipython
stonebig May 11, 2019
67e3ad2
MNT code reducer now includes pos-only args
pierreglaser May 13, 2019
2320516
TST test function with posonlyargument pickling
pierreglaser May 13, 2019
c9bec06
MNT use an attribute-based condition
pierreglaser May 13, 2019
f67f63a
MNT update changelog
pierreglaser May 13, 2019
30c84ee
fixup! TST test function with posonlyargument pickling
pierreglaser May 14, 2019
2133808
CI add python3.8 to travis
pierreglaser May 14, 2019
7349197
fixup! TST test function with posonlyargument pickling
pierreglaser May 14, 2019
d01cdf4
CI skip scipy tests on 3.8
pierreglaser May 14, 2019
7c5933e
fixup! CI skip scipy tests on 3.8
pierreglaser May 14, 2019
9c6cb35
CI use python nightly build
pierreglaser May 14, 2019
a219dde
fixup! CI use python nightly build
pierreglaser May 14, 2019
8a0974f
fixup! TST test function with posonlyargument pickling
pierreglaser May 14, 2019
1e555e3
CI increase coverage stats
pierreglaser May 14, 2019
a1330f6
fixup! CI increase coverage stats
pierreglaser May 14, 2019
e34e4f6
CI build python from source for new python versions
pierreglaser May 14, 2019
cff2e3a
[ci python-nightly]
pierreglaser May 14, 2019
dd75b20
stale variable
pierreglaser May 14, 2019
f70da00
[ci python-nightly]
pierreglaser May 14, 2019
5718fdf
fixup! CI build python from source for new python versions
pierreglaser May 14, 2019
c2e2cbe
[ci python-nightly]
pierreglaser May 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! TST test function with posonlyargument pickling
  • Loading branch information
@pierreglaser
pierreglaser committed May 14, 2019
commit 30c84eecdf0426a4526f5b0506d26bda209d260f
3 changes: 2 additions & 1 deletion tests/cloudpickle_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1639,7 +1639,7 @@ def f(a, *, b=1):
""".format(protocol=self.protocol)
assert_run_python_script(textwrap.dedent(code))

@pytest.mark.skipif(hasattr(types.CodeType, "co_posonlyargcount"),
@pytest.mark.skipif(not hasattr(types.CodeType, "co_posonlyargcount"),
reason="Not all python version support this syntax")
def test_interactively_defined_func_with_positional_only_argument(self):
# Fixes https://github.com/cloudpipe/cloudpickle/issues/266
Expand All @@ -1648,6 +1648,7 @@ def test_interactively_defined_func_with_positional_only_argument(self):
# in versions of python that do not support positional-only argument
# syntax.
code = """
import pytest
from cloudpickle import loads, dumps

def f(a, /, b=1):
Expand Down