Skip to content

recursive and unhashable closure #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 14 commits into from
May 30, 2017
+183 −19
Merged

recursive and unhashable closure #90

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
da4dd39
support recursive closure cells
May 25, 2017
ba23a20
support unhashable closure values
May 25, 2017
2c49ba0
pypy fixes and _cell_set definition update
May 25, 2017
4b251a0
test the expected failure for pypy
May 25, 2017
6d8ec33
add test for f.__closure__ preservation
May 25, 2017
9e11439
2.6 compat for TestCase.assertIsNone
May 25, 2017
121604a
don't send the closure twice on pypy
May 25, 2017
ac85930
update closure serialization for pypy
May 25, 2017
55cd6fd
use pytest.raises instead of xfail
May 25, 2017
cb524a4
support pypy
May 25, 2017
ed7a73c
clean up names and inline single-use functions
May 25, 2017
6656cca
add comment pointing out my one weird trick for mutating a cell
May 26, 2017
26c319c
use an empty cell instead of cell(None)
May 26, 2017
cf882c6
add cell manipulation helper unit tests
May 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
2.6 compat for TestCase.assertIsNone
  • Loading branch information
Joe Jevnik committed May 25, 2017
commit 9e11439ba59dd9c7013096537176229ddd488abc
9 changes: 6 additions & 3 deletions tests/cloudpickle_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,12 +163,15 @@ def f():
"""a function with no closure cells
"""

self.assertIsNone(f.__closure__, msg='f actually has closure cells!')
self.assertTrue(
f.__closure__ is None,
msg='f actually has closure cells!',
)

g = pickle_depickle(f)

self.assertIsNone(
g.__closure__,
self.assertTrue(
g.__closure__ is None,
msg='g now has closure cells even though f does not',
)

Expand Down