Adding engine_version to elasticache replication group arguments #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarkis
previously approved these changes
Jun 30, 2018
This is the newest available engine version available for Redis Elasticache.
sarkis
approved these changes
Jun 30, 2018
|
Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it is
Adds
engine_versionargument to the aws_elasticache_replication_group module.Why
Previously when referencing this module in an external terraform template any attempt to override the engine version was ignored because this option was unavailable. This resulted in AWS utilizing the default Redis engine (4.0), if attempting to make a cluster utilizing an older version of Redis (ex: 3.2.4) and referencing a parameter group using the family redis3.2 Terraform returns an error stating
Error creating Elasticache Replication Group: InvalidParameterCombination: Expected a parameter group of family redis4.0 but found one of family redis3.2.How I tested
Referenced this branch as the source of the module and used the variable
engine_versionto set to my desired engine version, spun up a cluster.