Upgrade to new securty-group standards #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
aknysh
reviewed
Oct 24, 2021
aknysh
reviewed
Oct 24, 2021
README.yaml
Outdated
| If this is not desired behavior, set `transit_encryption_enabled=false`. | ||
| This module creates, by default, a new security group for the Elasticache Redis Cluster. When necessary, it will | ||
| replace that security group with a new one. In order to allow terraform to fully manage the security group, you |
There was a problem hiding this comment.
When necessary, it will replace that security group with a new one
Not clear which one is "that" and which one is new (b/c the previous sentence says "This module creates, by default, a new security group").
Can you elaborate on this sentence?
aknysh
reviewed
Oct 24, 2021
aknysh
reviewed
Oct 24, 2021
aknysh
reviewed
Oct 24, 2021
aknysh
reviewed
Oct 24, 2021
variables-deprecated.tf
Outdated
| EOT | ||
| } | ||
| locals { | ||
| use_legacy_egress = var.egress_cidr_blocks != null && var.egress_cidr_blocks != ["0.0.0.0/0"] && var.allow_all_egress != true |
There was a problem hiding this comment.
Suggested change
| use_legacy_egress = var.egress_cidr_blocks != null && var.egress_cidr_blocks != ["0.0.0.0/0"] && var.allow_all_egress != true | |
| use_legacy_egress = var.egress_cidr_blocks != null && !(length(var.egress_cidr_blocks) == 1 && var.egress_cidr_blocks[0] == "0.0.0.0/0") && var.allow_all_egress == false |
Terraform does not support comparing lists using == and != operators, and can appear to work but will produce unexpected results
|
/test all |
aknysh
approved these changes
Oct 24, 2021
brian-weis-msr
pushed a commit
to Measurabl/terraform-aws-elasticache-redis
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
create_before_destroyon security groups by defaultwhy
references
Works around Terraform bug with using
coalesce()orcompact()in resource inputs.