Update outputs.tf #138
Closed
Update outputs.tf #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update reader_endpoint_address to null when cluster_mode_enabled true.
rafstef
requested review from
florian0410 and
milldr
and removed request for
a team
|
/test all |
nitrocode
reviewed
Oct 28, 2021
|
|
||
| output "reader_endpoint_address" { | ||
| value = join("", aws_elasticache_replication_group.default.*.reader_endpoint_address) | ||
| value = var.cluster_mode_enabled ? null : join("", aws_elasticache_replication_group.default.*.reader_endpoint_address) |
There was a problem hiding this comment.
Don't we also to make sure the module is also enabled ?
Suggested change
| value = var.cluster_mode_enabled ? null : join("", aws_elasticache_replication_group.default.*.reader_endpoint_address) | |
| value = local.enabled && var.cluster_mode_enabled ? null : join("", aws_elasticache_replication_group.default.*.reader_endpoint_address) |
If so, we'd probably want to add local.enabled to the endpoint output as well
There was a problem hiding this comment.
@nitrocode Close, but not quite. Also should verify/fix other outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update reader_endpoint_address to null when cluster_mode_enabled true.
what
Update reader_endpoint_address to null when cluster_mode_enabled is enabled.
why
references