Skip to content

Re-adding tag propagation for cloudwatch alarms #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2021
Merged

Re-adding tag propagation for cloudwatch alarms #147

merged 2 commits into from
Dec 30, 2021

Conversation

brucehajdu
Copy link
Contributor

@brucehajdu brucehajdu commented Dec 29, 2021 •
edited by nitrocode
Loading

what

In #7, the tag propagation was removed for CloudWatch metric alarms because the tags property did not exist at that time. This PR adds them back.

why

  • Terraform has had the capability to manage tags for aws_cloudwatch_metric_alarm resources for a while now, so I think we should add it back, as I think it makes sense for tags to propagate to all possible resources managed by the module.
  • This also helps me to comply with my organization's tagging policies without the hassle of manual intervention.

references

@brucehajdu brucehajdu requested review from a team as code owners December 29, 2021 18:49
@brucehajdu brucehajdu requested review from Makeshift and dylanbannon and removed request for a team December 29, 2021 18:49
@nitrocode nitrocode added the patch A minor, backward compatible change label Dec 30, 2021
@nitrocode
Copy link
Member

/test all

nitrocode
nitrocode approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nitrocode nitrocode merged commit 5934974 into cloudposse:master Dec 30, 2021
brian-weis-msr pushed a commit to Measurabl/terraform-aws-elasticache-redis that referenced this pull request Apr 2, 2024
@brucehajdu @nitrocode @brian-weis-msr
Re-adding tag propagation for cloudwatch alarms (cloudposse#147)
42cb812 
* Adding tag propagation for cloudwatch alarms

* Added tags to elasticache parameter group

Co-authored-by: nitrocode <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitrocode nitrocode nitrocode approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift Makeshift was automatically assigned from cloudposse/contributors

@dylanbannon dylanbannon Awaiting requested review from dylanbannon dylanbannon was automatically assigned from cloudposse/contributors

Assignees

No one assigned

Labels

patch A minor, backward compatible change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brucehajdu @nitrocode