Skip to content

Input variable for replication_group_id #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2018
Merged

Input variable for replication_group_id #28

merged 3 commits into from
Dec 7, 2018

Conversation

stephencoe
Copy link

Adding the option to override the replication_group_id since it has a restriction on character length. Currently the generated name doesn't leave a lot of space for applying a meaningful name.

Related issue #16

@osterman osterman requested a review from aknysh December 6, 2018 05:36
osterman
osterman requested changes Dec 6, 2018
View reviewed changes
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rebuild the readme.

make init
make readme/deps
make readme

@osterman
Copy link
Member

osterman commented Dec 6, 2018

Also, run terraform fmt

@aknysh aknysh requested a review from osterman December 6, 2018 21:28
@osterman osterman merged commit cb85357 into cloudposse:master Dec 7, 2018
@osterman
Copy link
Member

osterman commented Dec 7, 2018

thanks @stephencoe !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osterman osterman osterman approved these changes

@aknysh aknysh aknysh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephencoe @osterman @aknysh