Skip to content

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Aug 27, 2017

What

  • Assign attributes and tags from variables.tf to internal label module

Why

  • The internal label module's attributes and tags should be visible from outside of the top-level module
  • If attributes and tags are not accessible from outside, sometimes it's impossible to create more than one AWS resource from the top-level module
  • Without additional attributes, it's not possible at all to create aws_security_group inside the module since many security groups with the same name ${module.label.id} are created in the same solution

@aknysh aknysh added the enhancement New feature or request label Aug 27, 2017
@aknysh aknysh self-assigned this Aug 27, 2017
@aknysh aknysh requested review from goruha and osterman August 27, 2017 20:35
@aknysh aknysh merged commit 27f72db into master Aug 28, 2017
@aknysh aknysh deleted the add-attributes-and-tags branch August 28, 2017 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants