Skip to content

add cloudwatch ok alarm actions #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2018
Merged

add cloudwatch ok alarm actions #32

merged 2 commits into from
Dec 23, 2018

Conversation

@veilig2000
Copy link
Contributor

@veilig2000 veilig2000 commented Dec 18, 2018 •
edited by osterman
Loading

what

  • Allow ok actions to cloudwatch metrics so events can rotate back off alarm state.

why

  • To know when things recover =)

@aknysh aknysh requested review from aknysh and osterman December 21, 2018 04:51
osterman
osterman requested changes Dec 21, 2018
View reviewed changes
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @veilig2000 ! LGTM, but can you please run the following to rebuild the README:

make init
make readme/deps
make readme

aknysh
aknysh requested changes Dec 21, 2018
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veilig2000 thank you for the PR!
Looks good, but please don't modify README.md directly.
Instead, update README.yaml (the example), and then execute the following commands:

make init
make readme/deps
make readme

This will rebuild README taking into account all changes to variables and outputs.

thanks

@aknysh
Copy link
Member

aknysh commented Dec 21, 2018 •
edited
Loading

oops, same timing with @osterman :)

@veilig2000
Copy link
Contributor Author

veilig2000 commented Dec 21, 2018

@aknysh @osterman Sorry guys, I missed that - I made those changes through the makefile.

aknysh
aknysh approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @veilig2000

@aknysh aknysh requested a review from osterman December 21, 2018 15:28
@osterman osterman merged commit 277a6ed into cloudposse:master Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osterman osterman osterman approved these changes

@aknysh aknysh aknysh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@veilig2000 @aknysh @osterman