Skip to content

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Jul 13, 2019

what

  • Port module to Terraform 0.12
  • Pin all providers
  • Add example for testing
  • Add bats and terratest for the example
  • Add Codefresh badge to point to the test pipeline in terraform-modules project
  • Update README

why

  • Module currently does not work with 0.12. Much easier syntax
  • Better regression control
  • Automatically test the example on every commit and pull request
  • Provision resources on AWS in the test account and check the outputs for the correct values
  • terraform-modules project contains pipelines for all terraform modules

related

@aknysh aknysh requested a review from osterman July 13, 2019 05:37
@aknysh aknysh self-assigned this Jul 13, 2019
@aknysh aknysh merged commit 3f6856a into master Jul 14, 2019
@aknysh aknysh deleted the terraform-0.12 branch July 14, 2019 16:02
@jensenbox
Copy link

The example file looks like it is not for Elasticache but instead is for Elasticsearch.

Additionally, the link from the readme to the Example goes to a 404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants