Skip to content

Conversation

mazzy89
Copy link
Contributor

@mazzy89 mazzy89 commented Sep 9, 2019

Signed-off-by: Salvatore Mazzarino [email protected]

This gives the possibility to create enable automatic backups.

Could I also backport this change to a release before TF 0.12? So codebase that has not been migrated to TF would support this.

Thank you

@aknysh
Copy link
Member

aknysh commented Sep 9, 2019

/codefresh run test

@aknysh aknysh self-requested a review September 9, 2019 15:44
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mazzy89

Looks good, but please rebuild README by executing these commands:

make init
make readme/deps
make readme

It will add the new variables and outputs to README.md automatically.

In general, any changes to README should be made in README.yaml, and after that executing the commands above will rebuild README.yaml into README.md and add all new variables and outputs to README.md

thanks

image

@mazzy89
Copy link
Contributor Author

mazzy89 commented Sep 9, 2019

@aknysh make sense I'll do it

@mazzy89
Copy link
Contributor Author

mazzy89 commented Sep 9, 2019

@aknysh Fixed

Signed-off-by: Salvatore Mazzarino <[email protected]>
@mazzy89
Copy link
Contributor Author

mazzy89 commented Sep 9, 2019

/codefresh run test

1 similar comment
@aknysh
Copy link
Member

aknysh commented Sep 9, 2019

/codefresh run test

Signed-off-by: Salvatore Mazzarino <[email protected]>
@mazzy89
Copy link
Contributor Author

mazzy89 commented Sep 9, 2019

sorry @aknysh. Fixed README.

@aknysh
Copy link
Member

aknysh commented Sep 9, 2019

/codefresh run test

@mazzy89
Copy link
Contributor Author

mazzy89 commented Sep 9, 2019

@aknysh would it be possible to backport this change to a release prior of TF 0.12?

@aknysh
Copy link
Member

aknysh commented Sep 9, 2019

for TF 0.11, open a PR against 0.11/master branch
https://github.com/cloudposse/terraform-aws-elasticache-redis/tree/0.11/master

@mazzy89
Copy link
Contributor Author

mazzy89 commented Sep 9, 2019

Perfect. Thank you. I'm going to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants