do not limit to only v2, ensure we go to v3 of the aws provider which… #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has more tf 13 fixes
jurgenweber
requested review from
aknysh and
jamengual
and removed request for
a team
joe-niland
reviewed
Aug 21, 2020
joe-niland
requested changes
Aug 21, 2020
|
I have gone with the suggestions made by @aknysh here: cloudposse/terraform-aws-dynamodb#62 (comment) |
|
i think this PR can be closed. minimum version pinning was merged in #81 and the recommended best practice from hashicorp is to exclude introducing a max version in individual modules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… has more tf 13 fixes
what
do not restrict the aws provider version to just v2
why
cloudposse/terraform-aws-route53-cluster-hostname#23
the aws cloud provider has v13 fixes and requirements also
references
closes #79#79