Skip to content

Conversation

marcuz
Copy link
Contributor

@marcuz marcuz commented Dec 8, 2020

what

  • Allow empty egress_cidr_blocks (no egress rules in default security group)

why

  • Not mandatory to have an egress rule

references

@marcuz marcuz requested a review from a team as a code owner December 8, 2020 10:37
@marcuz marcuz requested review from adamcrews and brcnblc and removed request for a team December 8, 2020 10:37
@joe-niland joe-niland self-assigned this Dec 21, 2020
@marcuz
Copy link
Contributor Author

marcuz commented Jan 14, 2021

@adamcrews @brcnblc any chance to get some love on this please? 😃

@Gowiem
Copy link
Member

Gowiem commented Mar 10, 2021

/test all

Gowiem
Gowiem previously approved these changes Mar 10, 2021
@joe-niland
Copy link
Member

/rebuild-readme

@joe-niland
Copy link
Member

/test readme

@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2021

This pull request is now in conflict. Could you fix it @marcuz? 🙏

@Gowiem
Copy link
Member

Gowiem commented Mar 11, 2021

/test all

@Gowiem Gowiem merged commit 83bd076 into cloudposse:master Mar 11, 2021
@marcuz marcuz deleted the patch-1 branch March 11, 2021 15:35
brian-weis-msr pushed a commit to Measurabl/terraform-aws-elasticache-redis that referenced this pull request Apr 2, 2024
Co-authored-by: Joe Niland <[email protected]>
Co-authored-by: actions-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants