chore: Expose styles build as a standalone feature #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 47 47
Lines 2889 2891 +2
Branches 364 366 +2
=======================================
+ Hits 2762 2764 +2
Misses 123 123
Partials 4 4 ☔ View full report in Codecov by Sentry. |
just-boris
force-pushed
the
expose-styles-build
branch
from
3230045 to
2d8e7ec
Compare
just-boris
commented
Mar 13, 2024
| } | ||
|
|
||
| export async function createStyles(inlines: InlineStylesheet[], outputDir: string, sassDir: string) { | ||
| export async function buildStyles(sassDir: string, outputDir: string, inlines: InlineStylesheet[] = []) { |
Member
Author
There was a problem hiding this comment.
Updated this function to follow more intuitive signature "source, destination, options"
just-boris
commented
Mar 13, 2024
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| import sass from 'sass'; | ||
| import * as sass from 'sass'; |
Member
Author
There was a problem hiding this comment.
Fixing deprecation warning
`import sass from 'sass'` is deprecated.
Please use `import * as sass from 'sass'` instead.
just-boris
commented
Mar 13, 2024
| main: './build/index.js', | ||
| exports: { | ||
| '.': './build/index.js', | ||
| './internal': './build/internal.js' |
Member
Author
There was a problem hiding this comment.
Moving forward, we should replace all current imports
import { buildThemedComponentsInternal } from "@cloudscape-design/theming-build";to the new subpath
import { buildThemedComponentsInternal } from "@cloudscape-design/theming-build/internal";Follow our standard naming convention where all team-internal APIs are coming from /internal imports
avinashbot
approved these changes
Mar 15, 2024
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Allows simplified usage:
Currently we use some hacky options here and there. We can improve this
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.