Bug Fix to add Ingress for ArgoCD #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elamaran11
force-pushed
the
fix/missingArgoCDIngress
branch
from
eb7a114 to
5757748
Compare
Signed-off-by: Elamaran Shanmugam <[email protected]>
Signed-off-by: Elamaran Shanmugam <[email protected]>
Signed-off-by: Elamaran Shanmugam <[email protected]>
elamaran11
force-pushed
the
fix/missingArgoCDIngress
branch
from
e2699d7 to
dfbe046
Compare
nimakaviani
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
LGTM, as long as the risks of exposing Argo CD to the internet are assessed.
ideally, this should be done in an ephemeral cluster for testing purposes only. As @nabuskey said, Compromised ArgoCD = compromised cluster = compromised AWS account.
|
Agreed @nimakaviani . This is more of ingress for ArgoCD following the same principles with ingress for others. We should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix to add Ingress for ArgoCD