fix cert manager timeout #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nimakaviani Please approve this. This is another bug we found while using reference-implementation. |
nabuskey
requested changes
Sep 5, 2024
terraform/cert-manager.tf
Outdated
| }) | ||
| } | ||
|
|
||
| resource "null_resource" "wait_for_cert_manager" { |
There was a problem hiding this comment.
null_resource is deprecated. let's use what's suggested in the doc here: https://registry.terraform.io/providers/hashicorp/null/latest/docs/resources/resource
nabuskey
reviewed
Sep 6, 2024
There was a problem hiding this comment.
Thanks for making the change. Just have a question about the new module being added. Please also fix DCO so we can merge: https://github.com/apps/dco
terraform/versions.tf
Outdated
Comment on lines
21
to
24
| http = { | ||
| source = "hashicorp/http" | ||
| version = ">= 3.4.4" | ||
| } |
Signed-off-by: Zach Jacobson <[email protected]>
Signed-off-by: Zach Jacobson <[email protected]>
Signed-off-by: Zach Jacobson <[email protected]>
nabuskey
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a null resource to cert manager to stop the timeout when creating