pgwire: transmit 24:00 correctly for Time/TimeTZ #45387
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would resolve #44548, but has a few blockers to sort out.
We previously relied on golang's time.Time library to return 24:00 time
for us; however, time.Time does not parse 24:00 well, nor does it print
24:00 as on the same day (it uses the next day).
As such, when parsing or emitting time.Time, we have to be super weary
of how we output 24:00 time. Two major changes:
it can parse 24:00 time externally.
correctly handle 24:00 cases.
Release note (sql change, bug fix): 24:00 time now displays correctly in
the cli, returning
0001-01-02 00:00:00. Furthermore, backups correctlyemit and read in 24:00 time properly.