workload: use the same ctx for ramp and main load #70947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen issues where a worker returns ErrBadConn immediately after the ramp period is done. It comes down to the fact that connections in the pool are makred as "bad" when a context is canceled. The underlying issue might be a race condition in how lib/pq cancels the context and then marks the connection as "bad." But I'm not really sure how to fix that and it's hard to reproduce, so I'm working around the problem instead. Release note: None
Member
|
This change is |
otan
approved these changes
Oct 5, 2021
tbg
approved these changes
Oct 5, 2021
Collaborator
Author
|
bors r=otan,tbg |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #70019
fixes #69545
fixes #69523
We have seen issues where a worker returns ErrBadConn immediately after
the ramp period is done. It comes down to the fact that connections in
the pool are marked as "bad" when a context is canceled.
The underlying issue might be a race condition in how lib/pq cancels the
context and then marks the connection as "bad." But I'm not really sure
how to fix that and it's hard to reproduce, so I'm working around the
problem instead.
Release note: None