Skip to content

Fix memory leak if invoking Texture2D::setAlphaTexture many times. #19400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Fix memory leak if invoking Texture2D::setAlphaTexture many times. #19400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions cocos/renderer/CCTexture2D.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1499,10 +1499,12 @@ void Texture2D::removeSpriteFrameCapInset(SpriteFrame* spriteFrame)
/// halx99 spec, ANDROID ETC1 ALPHA supports.
void Texture2D::setAlphaTexture(Texture2D* alphaTexture)
{
if (alphaTexture != nullptr) {
this->_alphaTexture = alphaTexture;
this->_alphaTexture->retain();
this->_hasPremultipliedAlpha = true; // PremultipliedAlpha should be true.
if (alphaTexture != nullptr)
{
alphaTexture->retain();
CC_SAFE_RELEASE(_alphaTexture);
Copy link
Author

@dumganhar dumganhar Feb 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old alpha texture needs to be released.

_alphaTexture = alphaTexture;
_hasPremultipliedAlpha = true; // PremultipliedAlpha should be true.
}
}

Expand Down