Skip to content

Conversation

@mdentremont
Copy link
Contributor

No description provided.

@mdentremont mdentremont changed the title Support Angular 5 Support both Angular 4 & 5 Jan 3, 2018
@langley-agm
Copy link
Contributor

Remove the version number change please, npm should handle it when making the release.

@mdentremont
Copy link
Contributor Author

@langley-agm 👍

@mdentremont
Copy link
Contributor Author

@langley-agm Anything else I can do, or is it good to go?

@fmpierce
Copy link

fmpierce commented Feb 8, 2018

I hope this gets merged soon.

@langley-agm
Copy link
Contributor

@mdentremont an apology, I haven't had access to my pc for a while, lost my charger, I've been traveling and whatnot, if you guys have tested it and it works feel free to do the release so you don't have to wait, otherwise I have my personal laptop and charger now so I'll try my best to do it this weekend. I'll also try to make a guide on how to release so people don't have to wait for me in these scenarios. again I'm sorry !

@langley-agm langley-agm changed the base branch from master to feature/176 February 12, 2018 22:25
@langley-agm langley-agm merged commit 03b59dd into code-chunks:feature/176 Feb 12, 2018
@langley-agm
Copy link
Contributor

Merged and published, should be good now Guys, let me know if any issues arise !

@mdentremont @fmpierce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants