Skip to content

OpenCV3 support added #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cpaxton wants to merge 3 commits into from
Closed

OpenCV3 support added #199

cpaxton wants to merge 3 commits into from

Conversation

@cpaxton
Copy link

@cpaxton cpaxton commented Dec 31, 2015

No description provided.

@ahundt
Copy link

ahundt commented Dec 31, 2015

Despite the confusion in #200, this pull request should still be correct and both forwards and backwards compatible.

@kohrt
Copy link

kohrt commented Dec 31, 2015

Hi,
I already looked into the OpenCV 3.0 support. I added those changes (5ba0ebd) to the devel branch some time ago. But even if the code might support OpenCV 3.0, it will not work, because cv_bridge is compiled against OpenCV 2.4.x in Indigo and Jade.

@ahundt
Copy link

ahundt commented Jan 5, 2016

@wiedemeyer I don't think your changes will work on all versions of opencv2, particularly the #ifdef parts (see my ifdefs for comparison)

@kohrt
Copy link

kohrt commented Jan 5, 2016

@ahundt I used the example from the OpenCV transition guide, here: http://docs.opencv.org/master/db/dfa/tutorial_transition_guide.html#tutorial_transition_both
It also mentions to not use CV_VERSION_MAJOR.

@ahundt
Copy link

ahundt commented Jan 5, 2016

@wiedemeyer good point, missed that. Thanks

@ahundt
Change Readme to add point cloud publisher info
23a55bf 
Change pcl RBGA to RBG to fix the colorized pointcloud2
Fix Segmentation Fault problem in kinect2_viewer when using any visualisation
Fix topic reader in kinect2_viewer after adding point cloud publisher option
Fix point cloud publisher topic name to support as much kinect as possible
@kohrt
Copy link

kohrt commented Jan 8, 2016

I merged the devel branch commits to the master, therefore I will close this PR now.
Thanks for providing a PR.

@kohrt kohrt closed this Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cpaxton @ahundt @kohrt