Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor tests: Standardize assertion syntax and remove unused variables
  • Loading branch information
AnnaSasDev committed Dec 8, 2025
commit 7bf1bfcddf79c5937ea1975af31f39d5c5711c52
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public async Task GenericDebouncer_ConcurrentValues_ShouldBeThreadSafe() {
await debouncer.FlushAsync();

// Assert
await Assert.That(receivedValues).HasCount().EqualTo(1);
await Assert.That(receivedValues).Count().IsEqualTo(1);
await debouncer.DisposeAsync();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,6 @@ public async Task InvocationDuringDebounce_ShouldCancelPrevious_EventCallback()
await debouncer.FlushAsync();

// Assert
await Assert.That(executionTimes).HasCount().EqualTo(1);
await Assert.That(executionTimes).Count().IsEqualTo(1);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public async Task TryValidate_ValidInstance_ReturnsTrueAndNoFailures() {

[Test]
public async Task TryValidate_InvalidInstance_ReturnsFalseAndFailures() {
bool result = _mockedValidator.TryValidate(InvalidInstance, out List<ValidationFailure>? failures);
bool result = _mockedValidator.TryValidate(InvalidInstance, out List<ValidationFailure> failures);

await Assert.That(result).IsFalse();
await Assert.That(failures).IsEquivalentTo(ValidationFailures);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public async Task GenericDebouncer_ConcurrentValues_ShouldBeThreadSafe() {
await debouncer.FlushAsync();

// Assert
await Assert.That(receivedValues).HasCount().EqualTo(1);
await Assert.That(receivedValues).Count().IsEqualTo(1);
await debouncer.DisposeAsync();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,6 @@ public async Task InvocationDuringDebounce_ShouldCancelPrevious_Action() {
await debouncer.FlushAsync();

// Assert
await Assert.That(executionTimes).HasCount().EqualTo(1);
await Assert.That(executionTimes).Count().IsEqualTo(1);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public async Task GenericDebouncer_ConcurrentValues_ShouldBeThreadSafe() {
await debouncer.FlushAsync();

// Assert
await Assert.That(receivedValues).HasCount().EqualTo(1);
await Assert.That(receivedValues).Count().IsEqualTo(1);
await debouncer.DisposeAsync();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public async Task InvocationDuringDebounce_ShouldCancelPrevious_Func() {
await debouncer.FlushAsync();

// Assert
await Assert.That(executionTimes).HasCount().EqualTo(1);
await Assert.That(executionTimes).Count().IsEqualTo(1);
}

[Test]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public async Task ThrottledDebouncer_ThrottleBehavior_ShouldExecuteImmediatelyAf
await debouncer.FlushAsync(); // Ensure second execution has completed

// Assert
await Assert.That(receivedValues).HasCount().GreaterThanOrEqualTo(2);
await Assert.That(receivedValues).Count().IsGreaterThanOrEqualTo(2);
await Assert.That(receivedValues[0].Value).IsEqualTo("first");
await Assert.That(receivedValues[^1].Value).IsEqualTo("fourth");

Expand Down Expand Up @@ -123,7 +123,7 @@ public async Task ThrottledDebouncer_ContinuousRequests_ShouldRespectThrottleInt

// Assert
await Assert.That(executionCount).IsGreaterThan(1);
await Assert.That(receivedValues).HasCount().EqualTo(executionCount);
await Assert.That(receivedValues).Count().IsEqualTo(executionCount);
}

[Test]
Expand Down Expand Up @@ -171,7 +171,7 @@ await Task.WhenAll(
// Assert
await Assert.That(executionCount).IsGreaterThanOrEqualTo(2);
await Assert.That(executionCount).IsLessThanOrEqualTo(3);
await Assert.That(receivedValues).HasCount().EqualTo(executionCount);
await Assert.That(receivedValues).Count().IsEqualTo(executionCount);

}

Expand Down Expand Up @@ -246,7 +246,7 @@ public async Task ThrottledDebouncer_DefaultValues_ShouldUseDefaultDebounceAndTh
await debouncer.FlushAsync();

// Assert
await Assert.That(executionTimes).HasCount().EqualTo(1);
await Assert.That(executionTimes).Count().IsEqualTo(1);
double executionDelay = (executionTimes[0] - startTime).TotalMilliseconds;
await Assert.That(executionDelay).IsGreaterThanOrEqualTo(95); // Account for timing variations
}
Expand Down
6 changes: 5 additions & 1 deletion tests/Tests.CodeOfChaos.Extensions/ReflectionHelperTests.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// ---------------------------------------------------------------------------------------------------------------------
// Imports
// ---------------------------------------------------------------------------------------------------------------------
using System.Diagnostics.CodeAnalysis;
using System.Reflection;

namespace Tests.CodeOfChaos.Extensions;
Expand All @@ -9,7 +10,10 @@ namespace Tests.CodeOfChaos.Extensions;
// ---------------------------------------------------------------------------------------------------------------------
public class ReflectionHelperTests {
private class TestClass {
public TestClass(string nonNullable, string? nullable, int valueType, int? nullableValueType) {}// ReSharper disable UnusedParameter.Local
[SuppressMessage("ReSharper", "UnusedParameter.Local")]
public TestClass(string nonNullable, string? nullable, int valueType, int? nullableValueType) {}

[SuppressMessage("ReSharper", "UnusedParameter.Local")]
public static void MethodWithNullability(
string nonNullable,
string? nullable,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public async Task All() {
bool result = span.All(static x => x % 2 == 0);

// Assert
await Assert.That(result).IsTrue();;
await Assert.That(result).IsTrue();
}

[Test]
Expand Down
1 change: 0 additions & 1 deletion tests/Tests.CodeOfChaos.Extensions/TaskHelperTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ public async Task FromTaskOrDefault_ShouldReturnDefault_int(int? input, int? exp
[Arguments(false, false)]
public async Task FromTaskOrDefault_ShouldReturnExpected_ReferenceType(bool setAsDefault, bool expectedIsNull) {
// Arrange
var expected = new TestClass();
Task<TestClass?> task = Task.FromResult(setAsDefault ? null : new TestClass());

// Act
Expand Down
Loading