Skip to content

#3: toggle numbers display #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2020
Merged

#3: toggle numbers display #9

merged 1 commit into from
Oct 17, 2020

Conversation

gasp
Copy link
Contributor

@gasp gasp commented May 24, 2020

first time using reactn, thus not sure about using setState alongside setGlobal, yet, it works :-)

codealchemist
codealchemist reviewed Oct 15, 2020
View reviewed changes
@codealchemist
Copy link
Owner

codealchemist commented Oct 15, 2020 •
edited
Loading

This is sweet @gasp !
Just tested is and it's working great.
Thanks a lot 🙌

I left a comment about moving getValue into useEffect.
Maybe we can take that one back?
Everything else looks great 😀

@codealchemist codealchemist merged commit f4fb620 into codealchemist:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codealchemist codealchemist codealchemist left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gasp @codealchemist