Feat/esm #5045
Open
Feat/esm #5045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* better hooks handling by submitting where test.failed occur * reverted autologin plugin changes * small fix to screenshot failures * fixed screenshot tests * fixed PW tests * renamed autologin plugin to auth, added comment step * added check for the user in auth plugin --------- Co-authored-by: DavertMik <[email protected]>
* Bump eslint to ^9.19,0 * Bump eslint/js too
* injecting test & siute to container * added container const * fix: export STANDARD_ACTING_HELPERS type --------- Co-authored-by: DavertMik <[email protected]> Co-authored-by: kobenguyent <[email protected]>
…4810) Co-authored-by: DavertMik <[email protected]>
Co-authored-by: kobenguyent <[email protected]>
Bumps [semver](https://github.com/npm/node-semver) from 7.6.3 to 7.7.0. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.6.3...v7.7.0) --- updated-dependencies: - dependency-name: semver dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.12.0 to 22.13.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
The --debug flag was causing tests to hang after completion in CI. Replaced with --verbose for better output without the hanging issue. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Creates separate CI jobs for each Playwright test file with 3-minute timeouts. Uses fail-fast: false to continue even if one job fails. This will help identify which specific test file causes the 18-minute timeout. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Removed unnecessary artifact upload and updated to v4 to fix deprecation warning. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Created focused workflow to test specific scenarios with/without browser restart - Added local test script to debug timeout issue - Tests individual scenarios: within, config, session, and react tests - Each scenario has 3-minute timeout to identify problematic tests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Runs just one test ("within on form") with browser restart to confirm
that even individual tests cause the 18-minute timeout issue.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
Kept only the single test timeout debug workflow to isolate the issue. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Added a simple test (GitHub page load) to verify if the timeout issue occurs with basic tests that don't use complex features like 'within'. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Created separate jobs for simple and complex tests so they don't block each other. The simple test will run independently to verify if basic tests also timeout. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Prevents double cleanup and hanging when BROWSER_RESTART=browser or BROWSER_RESTART=context is used. The cleanup already happens in _after() and _afterSuite() hooks, so _finishTest() and _cleanup() are redundant and cause the process to hang trying to clean up an already closed browser. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Previous fix only checked individual helpers, but non-browser helpers like JSONResponse and ScreenshotSessionHelper also don't need cleanup when browser restarts. Now checks if ANY helper has restart enabled and skips _finishTest/_cleanup for all helpers in that case. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove browser restart option from Playwright helper due to hanging issues - Update PlaywrightRestartOpts.js to remove browser option and function - Remove restartBrowser method from Playwright helper - Update lib/listener/helpers.js to remove browser restart detection - Remove single-test-timeout.yml workflow - Update GitHub workflows to use context restart instead of browser restart - Update documentation to remove browser restart references - Remove debug test files The restart=browser strategy was causing tests to hang indefinitely due to browser context close promises never settling. This removal ensures more reliable test execution. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored to be fully ESM
Should be the base for 4.x branch