This repository was archived by the owner on Sep 16, 2021. It is now read-only.
Use git hash-object for blob id if available #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates file blob_id generation by first shelling out to `git hash-object`. If `git` or the file is unavailable, we'll fallback to our `sha1` computation.
|
|
||
| try { | ||
| stdout = childProcess.execSync("git hash-object " + path, { stdio: [0, "pipe", "ignore"] }); | ||
| } catch (e) { } |
There was a problem hiding this comment.
WDYT of adding a log here of "git hash-object failed. Falling back to manual calculation"?
There was a problem hiding this comment.
Since this called for every covered file, logging that out could get pretty noisy. On CI environments where git isn't installed, the operation would fail consistently for every file, potentially creating a lot of output.
I'd lean towards falling back gracefully, which we're doing here.
|
LGTM |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates file blob_id generation by first shelling out to
git hash-object. Ifgitor the file is unavailable, we'll fallback to oursha1computation.
@codeclimate/review 🔎