Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Fix incorrect exit code on repeated failed upload #157

Closed
eps1lon wants to merge 1 commit into from
Closed

Fix incorrect exit code on repeated failed upload #157

eps1lon wants to merge 1 commit into from

Conversation

@eps1lon
Copy link

@eps1lon eps1lon commented Jan 9, 2019

Caused mui-org/material-ui/pull/14125/63488 (test_unit) to exit with zero even if the upload failed and the script was called with -Z

Looks like an oversight in 7c92b4e#diff-45b1150df0237fb1cb2a238a2d04554eR991:

- exit $exit_with
+ exit 0
+ exit ${exit_with}

@eps1lon eps1lon mentioned this pull request Feb 21, 2019
Merged
@alex
Copy link
Contributor

alex commented Mar 29, 2020

What needs to happen to get this merged?

@thomasrockhu thomasrockhu mentioned this pull request Jun 4, 2020
Merged
@thomasrockhu
Copy link
Contributor

thomasrockhu commented Jun 4, 2020

Fixing and merging here

@eps1lon eps1lon deleted the patch-1 branch June 4, 2020 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eps1lon @alex @thomasrockhu