Merge pull request #232 from codecrafters-io/array-elements-assertion-fix

Fix Bug: ArrayElementsAssertion panics if value is an empty array

Author: UdeshyaDhungana

internal/resp_assertions/array_elements_assertion.go

@@ -15,7 +15,7 @@ type ArrayElementAssertionSpecification struct {
 }
 
 type ArrayElementsAssertion struct {
-	ArrayElementAssertionSpecification []ArrayElementAssertionSpecification
+	ArrayElementAssertionSpecifications []ArrayElementAssertionSpecification
 }
 
 func (a ArrayElementsAssertion) Run(value resp_value.Value) error {
@@ -27,11 +27,12 @@ func (a ArrayElementsAssertion) Run(value resp_value.Value) error {
 
 	array := value.Array()
 
-	if len(array) == 0 {
+	// If the specification is empty, panic
+	if len(a.ArrayElementAssertionSpecifications) == 0 {
 		panic("Codecrafters Internal Error - ArrayElementsAssertion called with empty specifications")
 	}
 
-	largestIndex := slices.MaxFunc(a.ArrayElementAssertionSpecification, func(a, b ArrayElementAssertionSpecification) int {
+	largestIndex := slices.MaxFunc(a.ArrayElementAssertionSpecifications, func(a, b ArrayElementAssertionSpecification) int {
 		return a.ArrayElementAssertion.Index - b.ArrayElementAssertion.Index
 	}).ArrayElementAssertion.Index
 
@@ -44,13 +45,13 @@ func (a ArrayElementsAssertion) Run(value resp_value.Value) error {
 	}
 
 	// Sort the indexes so the assertion runs serially
-	slices.SortFunc(a.ArrayElementAssertionSpecification, func(aea1, aea2 ArrayElementAssertionSpecification) int {
+	slices.SortFunc(a.ArrayElementAssertionSpecifications, func(aea1, aea2 ArrayElementAssertionSpecification) int {
 		return aea1.ArrayElementAssertion.Index - aea2.ArrayElementAssertion.Index
 	})
 
 	multiAssertion := MultiAssertion{}
 
-	for _, arrayElementAssertionSpecification := range a.ArrayElementAssertionSpecification {
+	for _, arrayElementAssertionSpecification := range a.ArrayElementAssertionSpecifications {
 		multiAssertion.AssertionSpecifications = append(multiAssertion.AssertionSpecifications, AssertionSpecification{
 			Assertion:            arrayElementAssertionSpecification.ArrayElementAssertion,
 			PreAssertionHook:     arrayElementAssertionSpecification.PreAssertionHook,

internal/test_cases/acl_getuser_test_case.go

@@ -27,7 +27,7 @@ func (t *AclGetuserTestCase) RunForFlagsTemplateOnly(client *instrumented_resp_c
 		Command: "ACL",
 		Args:    []string{"GETUSER", t.Username},
 		Assertion: resp_assertions.ArrayElementsAssertion{
-			ArrayElementAssertionSpecification: []resp_assertions.ArrayElementAssertionSpecification{
+			ArrayElementAssertionSpecifications: []resp_assertions.ArrayElementAssertionSpecification{
 				{
 					ArrayElementAssertion: resp_assertions.ArrayElementAssertion{
 						Index:     0,
@@ -83,7 +83,7 @@ func (t *AclGetuserTestCase) Run(client *instrumented_resp_connection.Instrument
 func (t *AclGetuserTestCase) addAssertionForFlags(assertion *resp_assertions.ArrayElementsAssertion, logger *logger.Logger) {
 	// Assert for flags
 	// Assertion for "flags" as the first element
-	assertion.ArrayElementAssertionSpecification = append(assertion.ArrayElementAssertionSpecification,
+	assertion.ArrayElementAssertionSpecifications = append(assertion.ArrayElementAssertionSpecifications,
 		resp_assertions.ArrayElementAssertionSpecification{
 			ArrayElementAssertion: resp_assertions.ArrayElementAssertion{
 				Index: 0,
@@ -104,7 +104,7 @@ func (t *AclGetuserTestCase) addAssertionForFlags(assertion *resp_assertions.Arr
 		})
 
 	// Assert the type of 2nd element to be array
-	assertion.ArrayElementAssertionSpecification = append(assertion.ArrayElementAssertionSpecification,
+	assertion.ArrayElementAssertionSpecifications = append(assertion.ArrayElementAssertionSpecifications,
 		resp_assertions.ArrayElementAssertionSpecification{
 			ArrayElementAssertion: resp_assertions.ArrayElementAssertion{
 				Index: 1,
@@ -158,7 +158,7 @@ func (t *AclGetuserTestCase) addAssertionForFlags(assertion *resp_assertions.Arr
 			})
 	}
 
-	assertion.ArrayElementAssertionSpecification = append(assertion.ArrayElementAssertionSpecification,
+	assertion.ArrayElementAssertionSpecifications = append(assertion.ArrayElementAssertionSpecifications,
 		resp_assertions.ArrayElementAssertionSpecification{
 			ArrayElementAssertion: resp_assertions.ArrayElementAssertion{
 				Index:     1,
@@ -168,7 +168,7 @@ func (t *AclGetuserTestCase) addAssertionForFlags(assertion *resp_assertions.Arr
 }
 
 func (t *AclGetuserTestCase) addAssertionForPasswords(assertion *resp_assertions.ArrayElementsAssertion, logger *logger.Logger) {
-	assertion.ArrayElementAssertionSpecification = append(assertion.ArrayElementAssertionSpecification,
+	assertion.ArrayElementAssertionSpecifications = append(assertion.ArrayElementAssertionSpecifications,
 		resp_assertions.ArrayElementAssertionSpecification{
 			ArrayElementAssertion: resp_assertions.ArrayElementAssertion{
 				Index: 2,
@@ -196,7 +196,7 @@ func (t *AclGetuserTestCase) addAssertionForPasswords(assertion *resp_assertions
 
 	}
 
-	assertion.ArrayElementAssertionSpecification = append(assertion.ArrayElementAssertionSpecification,
+	assertion.ArrayElementAssertionSpecifications = append(assertion.ArrayElementAssertionSpecifications,
 		resp_assertions.ArrayElementAssertionSpecification{
 			ArrayElementAssertion: resp_assertions.ArrayElementAssertion{
 				Index: 3,