Fix Bug: ArrayElementsAssertion panics if value is an empty array #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdeshyaDhungana
changed the title
Member
|
Thanks to @estenv for highlighting the issue! |
rohitpaulk
approved these changes
Nov 24, 2025
|
|
||
| if len(array) == 0 { | ||
| // If the specification is empty, panic | ||
| if len(a.ArrayElementAssertionSpecification) == 0 { |
Member
There was a problem hiding this comment.
Should this be a nil check instead? Don't think it's an array no?
Member
There was a problem hiding this comment.
Oh, ignore me - it is an array. @UdeshyaDhungana thoughts on renaming this to ArrayElementAssertionSpecifications? (plural)
The Specification word is kinda weird too, but don't have any better ideas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source: https://forum.codecrafters.io/t/redis-auth-test-run-crashes-gx8/15564
Note
ArrayElementsAssertion now panics only when the specification list is empty, and the field is pluralized with all call sites updated.
ArrayElementsAssertion.Runto trigger whenArrayElementAssertionSpecificationsis empty (was panicking on empty array value).ArrayElementAssertionSpecificationsand update all internal references (MaxFunc,SortFunc, iteration).AclGetuserTestCaseto useArrayElementAssertionSpecificationsand adjust all appends accordingly.Written by Cursor Bugbot for commit d97fbd9. This will update automatically on new commits. Configure here.