Skip to content

Conversation

slachiewicz
Copy link
Member

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Java version checks across test classes to support JDK 25, ensuring compiler tests work with the newest Java version. Additionally, it modernizes the AspectJ compiler's version handling with switch expressions.

  • Updates version checking logic in compiler tests to include JDK 25
  • Removes support for older JDK versions (22, 23, 24) in some test classes
  • Modernizes switch statement to use expression syntax in AspectJCompiler

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
JavaxToolsCompilerTest.java Updates version check to include JDK 25 instead of 24
AbstractJavacCompilerTest.java Adds JDK 25 support and removes intermediate versions from checks
JavacErrorProneCompilerTest.java Simplifies version check to only include JDK 21 and 25
EclipseCompilerTest.java Updates version check to include JDK 25 instead of 24
EclipseCompilerFailOnWarningsTest.java Updates version check to include JDK 25 instead of 24
EclipseCompilerErrorsAsWarningsTest.java Updates version check to include JDK 25 and removes JDK 9
AspectJCompiler.java Modernizes switch statement and adds support for JDK 17-21

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

…aus/plexus/compiler/javac/AbstractJavacCompilerTest.java

Co-authored-by: Copilot <[email protected]>
@slachiewicz slachiewicz merged commit e749517 into master Sep 23, 2025
9 of 39 checks passed
@slachiewicz slachiewicz deleted the adjust-to-jdk-25 branch September 23, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant