Date parsing using Regex on HTML#134
Closed
stripathi669 wants to merge 3 commits intocodelucas:masterfrom
Closed
Conversation
Owner
There was a problem hiding this comment.
Put this on a new line please, e.g.
get_publishing_date(
self.url,
self.clean_doc,
self.html
)
Owner
|
See my inline comments and add unit-tests please. This is a good start in expanding to the third layer of date parsing, via regex on html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have added third layer of date parsing using regex on HTML.
Method is fairly simple: Make Reg ex for all combos of DD, MM, and YYYY.
I understand that it might not be as accurate as first two layers. But I am making this PR anyways, as you requested.