-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix: use sufficient computational effort for password hash #3422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
dd2cb16
chore: update CHANGELOG
jsjoeio cac6673
refactor: use bcrypt in hash function
jsjoeio 17be8c5
refactor: use bcrypt in e2e setup
jsjoeio f35120c
feat: add unit test for hash function
jsjoeio aaf0447
refactor: add functions to check hash password
jsjoeio fc3326f
feat: add tests using real hashes
jsjoeio dc2db5c
chore: add argon2 package
jsjoeio 51f8341
chore: update to argon2 in test
jsjoeio 70197bb
refactor: use argon2 instead of bcrypt
jsjoeio fd3cb6c
refactor: update unit tests for hash fns
jsjoeio fcc3f0d
refactor: update login logic with new async hashing
jsjoeio 0cdbd33
refactor: make authenticated async everywhere
jsjoeio 91303d4
refactor: make ensureAuthenticated async
jsjoeio 1134780
refactor: make wsProxy async
jsjoeio 788b958
refactor: update hash fn in test config
jsjoeio ffa5c16
feat: update cli and test for hashed-password
jsjoeio 7ff4117
feat: add getPasswordMethod & test for it
jsjoeio a14ea39
feat: add handlePasswordValidation + tests
jsjoeio 409b473
refactor: rewrite password logic at /login
jsjoeio 6020480
feat: add isCookieValid function and tests
jsjoeio 923761c
refactor: password logic in http w/ isCookieValid
jsjoeio 517aaf7
docs: update FAQ with new hashing instructions
jsjoeio 531b7c0
feat: add splitOnFirstEquals function
jsjoeio 8c2bb61
refactor: parse options with multiple = in cli
jsjoeio deaa224
feat: add npm_config_build_from_source to build scripts
jsjoeio 3b50bfc
fix: sanitize password and cookie key
jsjoeio 1e55a64
feat: check for empty str in isHashMatch
jsjoeio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: add isCookieValid function and tests
- Loading branch information
commit 6020480b308d359f6f6ee0b55038f6ef9e1bc673
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.