Skip to content

fix: fix git url parsing #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrunoQuaresma merged 7 commits into from
May 14, 2024
+75 −14
Merged

fix: fix git url parsing #188

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1dbab82
fix: fix git url parsing
BrunoQuaresma May 14, 2024
c80fe81
Apply review suggestions
BrunoQuaresma May 14, 2024
022bf27
Merge branch 'main' into bq/fix-git-url-parse
BrunoQuaresma May 14, 2024
84b17d7
Add non valid URLs test case
BrunoQuaresma May 14, 2024
dcf67e9
Fix integration tests
BrunoQuaresma May 14, 2024
13e04f9
Fix another test
BrunoQuaresma May 14, 2024
815f009
Merge branch 'main' into bq/fix-git-url-parse
BrunoQuaresma May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix integration tests
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed May 14, 2024
commit dcf67e9d9c04b5713021db9f74ba175ec0216046
2 changes: 1 addition & 1 deletion integration/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func TestSucceedsGitAuthInURL(t *testing.T) {
envbuilderEnv("DOCKERFILE_PATH", "Dockerfile"),
}})
require.NoError(t, err)
gitConfig := execContainer(t, ctr, "cat /workspaces/.git/config")
gitConfig := execContainer(t, ctr, "cat /workspaces/empty/.git/config")
require.Contains(t, gitConfig, u.String())
}

Expand Down