-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Sanne/perf remove unused gql fields #8799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+0
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
christianalfoni
previously approved these changes
Sep 23, 2025
5e84120
to
b28eff9
Compare
0bfa2b8
to
a361f08
Compare
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
adf6c5a
to
a361f08
Compare
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
f22ff2d
to
2a52359
Compare
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
…com/codesandbox/codesandbox-client into sanne/perf-remove-unused-gql-fields
christianalfoni
approved these changes
Sep 25, 2025
tristandubbeld
approved these changes
Sep 25, 2025
sannek
added a commit
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to make the dashboard load a bit better, I looked for some quick wins in the GQL queries.
The biggest one is that we no longer show your 10 most recent sandboxes in the sidebar, but apparently still load them... Also the
likeCount
is apparently not used anywhere, and since that one requires an additional DB join, I removed it too.What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist