Skip to content

Conversation

HarsheetKakar
Copy link
Contributor

@HarsheetKakar HarsheetKakar commented Apr 1, 2020

References to other Issues or PRs or Relevant literature

Fixes #239

Brief description of what is fixed or changed

Other comments

Not sure on the implementation for DODA yet, further discussion is needed

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #241 into master will increase coverage by 0.010%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##            master      #241       +/-   ##
=============================================
+ Coverage   98.564%   98.575%   +0.010%     
=============================================
  Files           24        24               
  Lines         2090      2106       +16     
=============================================
+ Hits          2060      2076       +16     
  Misses          30        30               
Impacted Files Coverage Δ
pydatastructs/linear_data_structures/__init__.py 100.000% <ø> (ø)
pydatastructs/linear_data_structures/algorithms.py 100.000% <100.000%> (ø)

Impacted file tree graph

@czgdp1807
Copy link
Member

For DODA if a single None is found, an automatic TypeError would be raised, so we do not have to worry about Nones. More discussion on the patch later today.

@HarsheetKakar HarsheetKakar requested a review from czgdp1807 April 2, 2020 08:13
@HarsheetKakar
Copy link
Contributor Author

shall I move the helper function in the function itself?

@czgdp1807 czgdp1807 merged commit d05a6fb into codezonediitj:master Apr 2, 2020
@HarsheetKakar HarsheetKakar deleted the matrix branch April 2, 2020 16:24
Vanshika266 pushed a commit to Vanshika266/pydatastructs that referenced this pull request Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Matrix multiplication (sequential and parallel)

3 participants