Skip to content

Refactored the code as per CodeFactor #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Refactored the code as per CodeFactor #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/LetsDisc.Web.Host/src/app/account/login.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ export class LoginService {
providerKey: data.uid,
providerAccessCode: data.uid,
emailAddress: data.email,
name: data.displayName.split(" ")[0],
surname: data.displayName.split(" ")[1]
name: data.displayName.split(' ')[0],
surname: data.displayName.split(' ')[1]
});
this._tokenAuthService.externalAuthenticate(model)
.subscribe((result: ExternalAuthenticateResultModel) => {
Expand Down
2 changes: 1 addition & 1 deletion src/LetsDisc.Web.Host/src/app/posts/question-detail/question-detail.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export class QuestionDetailComponent extends AppComponentBase implements OnInit

deleteClicked(): void {
abp.message.confirm(
'Delete question ' + this.question.post.title + "'?",
'Delete question "' + this.question.post.title + '"?',
(result: boolean) => {
if (result) {
this._postService.delete(this.question.post.id)
Expand Down
6 changes: 3 additions & 3 deletions src/LetsDisc.Web.Host/src/app/users/user-detail/user-detail.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class UserDetailComponent extends AppComponentBase implements OnInit {
url: string;
questions: PostDto[] = null;
answers: AnswerWithQuestion[] = null;
displayImage: boolean = false;
displayImage = false;
public pageSize = 10;
public questionPageNumber = 1;
public questionTotalPages = 1;
Expand All @@ -43,7 +43,7 @@ export class UserDetailComponent extends AppComponentBase implements OnInit {
public answerTotalPages = 1;
public answerTotalItems: number;
public answerIsTableLoading = false;
letter: string = '';
letter: string;

itemPluralMapping = {
'answer': {
Expand Down Expand Up @@ -136,7 +136,7 @@ export class UserDetailComponent extends AppComponentBase implements OnInit {
}

private getPagedRequest(page: number) {
let req = new PagedRequestDto();
const req = new PagedRequestDto();
req.maxResultCount = this.pageSize;
req.skipCount = (page - 1) * this.pageSize;
return req;
Expand Down
90 changes: 49 additions & 41 deletions src/LetsDisc.Web.Host/src/bsb-theme/css/materialize.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,6 @@ form p:last-child {
opacity: 0;
}

[type="checkbox"] {
/* checkbox aspect */
}

[type="checkbox"] + label {
position: relative;
padding-left: 35px;
Expand Down Expand Up @@ -228,20 +224,24 @@ form p:last-child {

/* Indeterminate checkbox */
[type="checkbox"]:indeterminate + label:before {
top: -11px;
left: -12px;
width: 10px;
height: 22px;
border-top: none;
border-left: none;
border-right: 2px solid #26a69a;
border-bottom: none;
-webkit-transform: rotate(90deg);
transform: rotate(90deg);
-webkit-backface-visibility: hidden;
backface-visibility: hidden;
-webkit-transform-origin: 100% 100%;
transform-origin: 100% 100%;
top: -11px;
left: -12px;
width: 10px;
height: 22px;
border-top: none;
border-left: none;
border-right: 2px solid #26a69a;
border-bottom: none;
-webkit-transform: rotate(90deg);
-ms-transform: rotate(90deg);
-moz-transform: rotate(90deg);
-o-transform: rotate(90deg);
-webkit-backface-visibility: hidden;
backface-visibility: hidden;
-webkit-transform-origin: 100% 100%;
-ms-transform-origin: 100% 100%;
-moz-transform-origin: 100% 100%;
-o-transform-origin: 100% 100%;
}

[type="checkbox"]:indeterminate:disabled + label:before {
Expand All @@ -264,39 +264,47 @@ form p:last-child {
}

[type="checkbox"].filled-in:not(:checked) + label:before {
width: 0;
height: 0;
border: 3px solid transparent;
left: 6px;
top: 10px;
-webkit-transform: rotateZ(37deg);
transform: rotateZ(37deg);
-webkit-transform-origin: 20% 40%;
transform-origin: 100% 100%;
width: 0;
height: 0;
border: 3px solid transparent;
left: 6px;
top: 10px;
-webkit-transform: rotateZ(37deg);
-ms-transform: rotateZ(37deg);
-moz-transform: rotateZ(37deg);
-o-transform: rotateZ(37deg);
-webkit-transform-origin: 100% 100%;
-ms-transform-origin: 100% 100%;
-moz-transform-origin: 100% 100%;
-o-transform-origin: 100% 100%;
}

[type="checkbox"].filled-in:not(:checked) + label:after {
height: 20px;
width: 20px;
background-color: transparent;
border: 2px solid #5a5a5a;
top: 0px;
top: 0;
z-index: 0;
}

[type="checkbox"].filled-in:checked + label:before {
top: 0;
left: 1px;
width: 8px;
height: 13px;
border-top: 2px solid transparent;
border-left: 2px solid transparent;
border-right: 2px solid #fff;
border-bottom: 2px solid #fff;
-webkit-transform: rotateZ(37deg);
transform: rotateZ(37deg);
-webkit-transform-origin: 100% 100%;
transform-origin: 100% 100%;
top: 0;
left: 1px;
width: 8px;
height: 13px;
border-top: 2px solid transparent;
border-left: 2px solid transparent;
border-right: 2px solid #fff;
border-bottom: 2px solid #fff;
-webkit-transform: rotateZ(37deg);
-ms-transform: rotateZ(37deg);
-moz-transform: rotateZ(37deg);
-o-transform: rotateZ(37deg);
-webkit-transform-origin: 100% 100%;
-ms-transform-origin: 100% 100%;
-moz-transform-origin: 100% 100%;
-o-transform-origin: 100% 100%;
}

[type="checkbox"].filled-in:checked + label:after {
Expand Down Expand Up @@ -342,7 +350,7 @@ form p:last-child {
/* Switch
========================================================================== */
.switch,
.switch * {
.switch label, .switch input, .switch span {
-webkit-user-select: none;
-moz-user-select: none;
-khtml-user-select: none;
Expand Down
Loading